Keith Kyzivattext not yet in the index
I don't see the problem right now - You are seeing a crash in 5.15.2, since when exactly?
12 January 2022
My question was - why did you add:
if (!sbkObj->ob_dict)
sbkObj->ob_dict = PyDict_New();
? Your commit message talks about the #ifdef PYPY_VERSION case, but doesn't talk about this change.
This change is for PySide6 only and addresses simplified dict access. Before, there was a check if the dict exists, which complicated the code. The reason was in fact to make PyPy work and avoid #ifdef in the code.
I don't think that it is relevant performance-wise, since in most cases attributes are used, anyway.
Welcome Ingrid 🎉 🎊
Remember to check the documentation page https://doc.qt.io/qtforpython/ and the wiki https://pyside.org if you have some questions.
Keith Kyzivattext not yet in the index
Did the ob_dict patch land in PySide2? This is a bad effect of merging, then. We back-ported support for Python 3.10, which had maybe some side-effects?
Christian Tismer-SperlingDid the ob_dict patch land in PySide2? This is a bad effect of merging, then. We back-ported support for Python 3.10, which had maybe some side-effects?
No, it didn't. I was just comparing the code around the crash between PySide2 and dev (PySide6)
Christian Tismer-SperlingI don't see the problem right now - You are seeing a crash in 5.15.2, since when exactly?
The version of PySide2 they're using is 5.15.2 (last open source version)
Welcome @kastakin 🎉 🎊
Remember to check the documentation page https://doc.qt.io/qtforpython/ and the wiki https://pyside.org if you have some questions.
Christian Tismer-SperlingI don't see the problem right now - You are seeing a crash in 5.15.2, since when exactly?
Oh and I believe it's before the newest 5.15.2.1 (I think that's what you're calling it) release.
That's the release with Python 3.10 support, right?
@Keithel yeah, it's planned, and I backported a couple of changes, that you can see the chain here: https://codereview.qt-project.org/c/pyside/pyside-setup/+/388586/11